Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate files in stimuli directories for some datasets #376

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Jun 2, 2023

relates to #373

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 3, 2023

thanks @VisLab

@sappelhoff we should also probably zero the stim from https://github.com/bids-standard/bids-examples/tree/master/ds000117/stimuli

no?

@sappelhoff
Copy link
Member

@sappelhoff we should also probably zero the stim from https://github.com/bids-standard/bids-examples/tree/master/ds000117/stimuli

agreed.

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 5, 2023

du -h -d 1   | sort -rh

7,7M    ./ds210
7,6M    ./fnirs_automaticity
4,6M    ./motion_dualtask
4,5M    ./ds000117
3,1M    ./ds110
2,7M    ./synthetic
2,2M    ./ds107
1,5M    ./ds116
1,5M    ./ds000247
1,4M    ./ieeg_visual_multimodal
1,4M    ./eeg_rest_fmri
1,4M    ./7t_trt
1,3M    ./ds109
1,3M    ./ds108
1,2M    ./ieeg_visual
1,2M    ./eeg_ds000117
1,1M    ./pet002
1,1M    ./eeg_rishikesh
1,1M    ./ds006
1,1M    ./ds000001-fmriprep
1012K   ./ds009
992K    ./ds051
968K    ./ieeg_motorMiller2007
944K    ./eeg_matchingpennies
908K    ./ds007
872K    ./ds008
824K    ./motion_spotrotation
804K    ./ieeg_filtered_speech
804K    ./eeg_face13
800K    ./ds113b
796K    ./ds002
744K    ./ds001
612K    ./ds101
604K    ./ds005
596K    ./ds011
576K    ./ds114
544K    ./ds102
500K    ./eeg_cbm
496K    ./ds000246
464K    ./pet005
456K    ./asl003
408K    ./genetics_ukbb
396K    ./eeg_ds003645s_hed_longform
396K    ./ds000248
388K    ./eeg_ds003645s_hed
388K    ./ds052
376K    ./ds105
348K    ./eeg_ds003645s_hed_inheritance
296K    ./ds004332
288K    ./qmri_mpm
272K    ./pet001
236K    ./ds003
224K    ./eeg_ds003645s_hed_library
216K    ./ieeg_epilepsyNWB
208K    ./asl004
200K    ./fnirs_tapping
196K    ./motion_systemvalidation
196K    ./asl005
180K    ./asl002
176K    ./qmri_mese
172K    ./ieeg_epilepsy_ecog
164K    ./pet003
156K    ./ieeg_epilepsy
140K    ./asl001
116K    ./micr_SPIM
104K    ./qmri_sa2rage
100K    ./micr_SEMzarr
92K     ./qmri_mtsat
88K     ./micr_SEM
80K     ./qmri_mp2rageme
76K     ./qmri_vfa
76K     ./pet004
64K     ./qmri_irt1
56K     ./qmri_mp2rage
52K     ./qmri_megre
44K     ./qmri_qsm
32K     ./hcp_example_bids
24K     ./qmri_tb1tfl

If we wanted to remove things that are a bit unnecessary the next target would be in the fnirs automaticity dataset that has a lot code in the stimuli folder that are just duplication of almost exactly the same code for each participant but that in total amounts to 2 Mo...

@sappelhoff sappelhoff changed the title Set files in stimuli directory to have zero length for HED examples issue #373 truncate files in stimuli directories for some datasets Jun 5, 2023
@sappelhoff
Copy link
Member

we reduce around 40-50MB with the changes here, from my side that's good enough for now. However if we will rewrite history later (to actually shrink the repo size for full git clones), then perhaps it'd be good to reduce as much as possible (so yes for reducing automaticity as well then).

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 5, 2023

we reduce around 40-50MB with the changes here, from my side that's good enough for now. However if we will rewrite history later (to actually shrink the repo size for full git clones), then perhaps it'd be good to reduce as much as possible (so yes for reducing automaticity as well then).

I am sort of torn on the same line as you on this: let's maybe wait until our next BIDS maintainers meeting to decide. I think that this issue can defo wait until then.

@Remi-Gau
Copy link
Contributor

I removed the large code duplication from fnirs_automaticity

Not sure I see anything else to optimize.

@sappelhoff
What are the next steps? Merge this and then rewrite the history?

@sappelhoff
Copy link
Member

Thanks!

What are the next steps? Merge this and then rewrite the history?

I would say yes!

@Remi-Gau Remi-Gau merged commit c557d1f into bids-standard:master Jul 14, 2023
@Remi-Gau
Copy link
Contributor

@sappelhoff
We should plan a session where we are both online to do the history rewrite.

@sappelhoff
Copy link
Member

agreed, let's DM on mattermost to make this happen. I'm in Berlin timezone wise.

@VisLab VisLab deleted the stim-zero branch July 15, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants