ENH: Add models for ds003, ds114 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial capitals in JSON keys * snake_case for variables * AutoContrasts for dataset-level analysis * High-pass filter cutoff
* Initial capitals in JSON keys * snake_case for variables * AutoContrasts for dataset-level analysis * High-pass filter cutoff Additionally, moved Split transformation to subject level, eliminating session-level step
|
@tyarkoni @adelavega If you get a chance, could you check to see if I updated these models correctly? I did some simplifying in addition to updating syntax, but since there's nothing that actually reads these, yet, it's hard to be sure. |
|
LGTM, but yeah, I guess we won't know for sure until pybids is updated. |
|
Same. Well, or the validation schema is complete. |
|
any news on this @effigies ? |
|
Thanks for the bump. I'll update these with models that conform to the latest spec today. @tyarkoni Do we want to set a timeline on preparing a release candidate of the spec? With pybids and fitlins finally in pretty good shape, it's probably a good time to plan a push. |
effigies
changed the title
|
closing this for dealing with the history issue discussed in #119. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet conformant with latest changes in BEP 002.
ds000030 an ds000117, for which models either exist or are in-progress, are not represented in this repository.
Closes #129.