Fix Code Splitting example for ClojureScirpt 1.11+ #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figwheel serves the static files from the `target/public/` folder so the `target` prefix in the `target/cljs-out/*.js` script src paths are incorrect. This commit fixes the script paths in the index.html host page so the browser doesn't show 404 responses for the compiled js files.
The goog.dom/createDom function requires a second argument of `opt_attributes`. (See at https://google.github.io/closure-library/api/goog.dom.html.) In previous ClojureScript versions, the goog.dom/createDom function was able to handle the nonexistence of `opt_attributes` argument, miraculously. However, with ClojureScript 1.11.60, this is considered an error: dom.js:171 Uncaught TypeError: Cannot set property assignedSlot of #<Element> which has only a getter at dom.js:171:20 at Object.forEach (object.js:11:7) at goog.dom.setProperties (dom.js:156:15) at goog.dom.createDom_ (dom.js:264:16) at goog.dom.createDom (dom.js:252:19) at foo$core$listen_to_button (core.cljs:11:17) at core.cljs:23:16 This commit fixes the error above and is tested on both ClojureScript 1.11.60 and ClojureScript 1.10.773.
dawranliou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following two things:
Incorrect script paths in
Index.htmlFigwheel serves the static files from the
target/public/folder so thetargetprefix in thetarget/cljs-out/*.jsscript src paths are incorrect.This commit fixes the script paths in the index.html host page so the browser
doesn't show 404 responses for the compiled js files.
goog.dom.createDomerror in cljs 1.11+The
goog.dom/createDomfunction requires a second argument ofopt_attributes. (See official documentation athttps://google.github.io/closure-library/api/goog.dom.html.) In previous
ClojureScript versions, the
goog.dom/createDomfunction was able to handle thenonexistence of
opt_attributesargument, miraculously. However, withClojureScript 1.11.60, this is considered an error:
This PR fixes the errors above and is tested on both ClojureScript 1.11.60
and ClojureScript 1.10.773.
See https://github.com/dawranliou/figwheel-main-code-splitting-demo for the
working demo.