Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#648 add Conditional primitive supports params in path #651

Closed
wants to merge 12 commits into from
Closed

#648 add Conditional primitive supports params in path #651

wants to merge 12 commits into from

Conversation

YuqiXiao
Copy link
Member

Signed-off-by: xiaoyuqi [email protected]

Detail see issue648

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #651 into develop will increase coverage by 0.06%.
The diff coverage is 59.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
+ Coverage    52.18%   52.24%   +0.06%     
===========================================
  Files          288      289       +1     
  Lines        22325    22450     +125     
===========================================
+ Hits         11650    11730      +80     
- Misses        9081     9110      +29     
- Partials      1594     1610      +16     
Impacted Files Coverage Δ
bfe_basic/condition/build.go 22.12% <0.00%> (-1.05%) ⬇️
bfe_basic/condition/parser/semant.go 80.00% <ø> (ø)
bfe_basic/condition/variable.go 70.47% <70.47%> (ø)
bfe_util/fixed_pool.go 77.77% <0.00%> (-22.23%) ⬇️
bfe_spdy/server_conn.go 77.09% <0.00%> (-0.50%) ⬇️
bfe_http2/server.go 70.71% <0.00%> (+0.17%) ⬆️
bfe_basic/condition/primitive.go 47.05% <0.00%> (+0.30%) ⬆️
bfe_spdy/frame_read.go 53.75% <0.00%> (+0.83%) ⬆️
bfe_spdy/frame_write.go 46.32% <0.00%> (+1.12%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba100b...1f3f37a. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 9 committers have signed the CLA.

✅ iyangsj
✅ zwj13513118235
✅ liuximu
✅ YuqiXiao
✅ weiliujia
✅ zhouhaibing
✅ zhangxiaogang01
❌ zsyzsqyxc
❌ zyf0411
You have signed the CLA already but the status is still pending? Let us recheck it.

@YuqiXiao YuqiXiao closed this Sep 24, 2020
@YuqiXiao
Copy link
Member Author

recommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.