Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-80: CEE diagnostic gathering mechanism #17

Merged
merged 6 commits into from
Feb 9, 2022
Merged

ADR-80: CEE diagnostic gathering mechanism #17

merged 6 commits into from
Feb 9, 2022

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Feb 8, 2022

Draft and placeholder for ADR 78

Signed-off-by: kwall [email protected]

@k-wall
Copy link
Contributor Author

k-wall commented Feb 8, 2022

@tombentley @emmanuelbernard could you review please?

Draft and placeholder for ADR 78

Signed-off-by: kwall <[email protected]>
@k-wall k-wall changed the title ADR-78: CEE diagnostic gathering mechanism ADR-80: CEE diagnostic gathering mechanism Feb 8, 2022
+ add authz
Copy link
Contributor

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos, but LGTM.

_adr/80/index.adoc Outdated Show resolved Hide resolved
_adr/80/index.adoc Outdated Show resolved Hide resolved
_adr/80/index.adoc Outdated Show resolved Hide resolved
k-wall and others added 4 commits February 8, 2022 14:38
@k-wall
Copy link
Contributor Author

k-wall commented Feb 8, 2022

@emmanuelbernard would you mind merging?

@emmanuelbernard
Copy link
Contributor

I will merge it but I think it needs a different title.

Since these are open source, any obscure function name is not helping.
I propose to rename CEE with a support organization.

The one other question I had was whether it was java diagnosing or generic diagnosing mechanism regardless of technology? That might also influence the title.

CC @k-wall

@tombentley where can we capture these generic writing guidelines?
Anther one is to one line per sentence model that we can discuss but that I've found useful in markdown and asciidoc documents https://emmanuelbernard.com/blog/2014/10/06/one-line-per-ide-feedback/

Finally where should I bring these feedback on a proto ADR? An issue created already? Here in the PR about to be merged?

@emmanuelbernard emmanuelbernard merged commit 97664ed into bf2fc6cc711aee1a0c2a:main Feb 9, 2022
@tombentley
Copy link
Contributor

@emmanuelbernard

@tombentley where can we capture these generic writing guidelines?

pages/about/adr-process.adoc is probably the best place for now, but we might want to have separate pages for the ADR process vs the ADR content. I've opened #36 to track the need for this doc.

Finally where should I bring these feedback on a proto ADR? An issue created already? Here in the PR about to be merged?

I've opened #35 if that's what you mean by proto ADR? If so, feel free to comment there.

@emmanuelbernard
Copy link
Contributor

I've opened #35 if that's what you mean by proto ADR? If so, feel free to comment there.

No I meant where / how to discuss the content of ADR-80. Sorry for my "creative" namings.

@tombentley
Copy link
Contributor

Comments on the PR then. I think issues in this repo should be limited to:

  • Proposed ADRs
  • Issues for the website itself (tracking tasks we want to get to eventually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants