-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR-80: CEE diagnostic gathering mechanism #17
ADR-80: CEE diagnostic gathering mechanism #17
Conversation
@tombentley @emmanuelbernard could you review please? |
Draft and placeholder for ADR 78 Signed-off-by: kwall <[email protected]>
+ add authz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos, but LGTM.
Co-authored-by: Tom Bentley <[email protected]>
Co-authored-by: Tom Bentley <[email protected]>
Co-authored-by: Tom Bentley <[email protected]>
@emmanuelbernard would you mind merging? |
I will merge it but I think it needs a different title. Since these are open source, any obscure function name is not helping. The one other question I had was whether it was java diagnosing or generic diagnosing mechanism regardless of technology? That might also influence the title. CC @k-wall @tombentley where can we capture these generic writing guidelines? Finally where should I bring these feedback on a proto ADR? An issue created already? Here in the PR about to be merged? |
pages/about/adr-process.adoc is probably the best place for now, but we might want to have separate pages for the ADR process vs the ADR content. I've opened #36 to track the need for this doc.
I've opened #35 if that's what you mean by proto ADR? If so, feel free to comment there. |
No I meant where / how to discuss the content of ADR-80. Sorry for my "creative" namings. |
Comments on the PR then. I think issues in this repo should be limited to:
|
Draft and placeholder for ADR 78
Signed-off-by: kwall [email protected]