-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BuilderCAI static caches into new BuilderCaches file. #1890
base: master
Are you sure you want to change the base?
Refactor BuilderCAI static caches into new BuilderCaches file. #1890
Conversation
|
||
class CUnit; | ||
|
||
class CBuilderCaches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's an instanceless class (not even a singleton needed) perhaps it should be a namespace with regular functions? See #1651 (comment)
#include "Sim/Units/UnitHandler.h" | ||
#include "Sim/Units/Unit.h" | ||
|
||
// not adding to members, should repopulate itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously it was obvious what "members" were because this chunk was right under a bunch of creg registrations
// not adding to members, should repopulate itself | |
// not adding to creg, should repopulate itself |
@@ -0,0 +1,147 @@ | |||
#include "Sim/Units/CommandAI/BuilderCaches.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs the licence notice at the top (as Spring, since it's entirely old code)
#include "Sim/Units/CommandAI/BuilderCaches.h" | |
/* This file is part of the Spring engine (GPL v2 or later), see LICENSE.html */ | |
#include "Sim/Units/CommandAI/BuilderCaches.h" |
Work done
Remarks