Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the min and max fields from LayoutContext. #16459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove the min and max fields from LayoutContext. #16459

wants to merge 2 commits into from
+6 −14

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Nov 21, 2024 •
edited
Loading

Objective

Remove the min and max fields from LayoutContext.
It doesn't seem useful to cache these values, it's simpler just to call min_element and max_element on the physical_size
field.

Migration Guide

The min and max fields have been removed from LayoutContext. To retrieve these values call min_element and max_element on LayoutContent::physical_size instead.

@ickshonpe
Removed the min and max fields from LayoutContext. It doesn't s…
ecc869a 
…eem to make any sense to cache these values, better to just use the `min_element` and `max_element` methods on the `physical_size` field.
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets D-Trivial Nice and easy! A great choice to get started with Bevy labels Nov 21, 2024
@rparrett rparrett added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@ickshonpe ickshonpe added the C-Code-Quality A section of code that is hard to understand or change label Nov 21, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 22, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
4 participants
@ickshonpe @alice-i-cecile @BenjaminBrienen @rparrett