Update Dockerfile to fix H7RF builds. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds vim-common which includes xxd, this is needed to build the H7RF target.
|
@AlessandroAU did you try: Also maybe we should update Ubuntu to 20.04. |
|
I think I tried that and it wasn't able to find the package. |
|
btw, this isn't specific to the H7RF, it's specific to all the EXST targets, such as the SPRacingH7EXTREME/NANO/ZERO |
|
This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
haslinghuis
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The H7RF target (and possibly others?) needs the xxd utility. This is not included in the current Docker file. I was not able to include xxd directly for some reason, but it is included as part of vim-common.