-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ToolTip for AirMode #4206
add ToolTip for AirMode #4206
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
so many words to confuse the pilot 😆 and use of "you" as the pilot. oh i see that came from the .com, how about i link the .com? |
Perhaps: In standard mode, when roll, pitch, and yaw calculations saturate a motor, all motors are equally reduced. If a motor goes below minimum, it gets clipped off. For example, with throttle just above minimum and a quick roll is attempted, two motors can't go any lower, resulting in half the power (half of the PID gain). If inputs demand more than a 100% difference between high and low motors, the low motors get clipped, causing an imbalance by unevenly reducing the gain. |
…h until translated. Co-authored-by: Mark Haslinghuis <[email protected]>
a5e1ca3
to
b33959c
Compare
|
Such a big pop-over element might cause UX and UI style issues, I think shortening it is more beneficial than having it be fully detailed. If links work in tooltip boxes, might be a good idea to link to the wiki for the full explanation |
thanks @VitroidFPV , I really agree, i think i'll revert to short text (+link) next work-week unless there are more comments to the contrary. |
@VitroidFPV @KarateBrot @mituritsyn |
I personnaly vote for @ctzsnooze formulation: |
Co-authored-by: Jan Post <[email protected]>
Quality Gate passedIssues Measures |
:(
i was still editing, but my internet provider is going hay-wire. i was not
ready for merge.
i did not like the word `drone` as `locales/en/messages.json` only uses it
one other instance. and also wanted to account for Mike's preference.
|
Apologies assumed this was ready after 24 hours cool of period. |
i try to stay offline on weekends. saw the comments this morning, but
internet intermittent.
```diff
diff --git a/locales/en/messages.json b/locales/en/messages.json
index 94199765..d86ce3c2 100755
--- a/locales/en/messages.json
+++ b/locales/en/messages.json
@@ -1324,7 +1324,9 @@
"message": "Permanently enable Airmode"
},
"featureAIRMODETip": {
- "message": "$t(auxiliaryHelpMode_AIRMODE.message)"
+ "message": "$t(auxiliaryHelpMode_AIRMODE.message)",
+ "description": "Don't translate!!!"
+
},
"featureRX_SPI": {
"message": "SPI Rx (e.g. built-in Rx)"
@@ -2411,7 +2413,7 @@
"description": "Help text to ANTIGRAVITY mode"
},
"auxiliaryHelpMode_AIRMODE": {
- "message": "AirMode allows for maintaining PID control at low throttle. For more information please see <a href=\"https://betaflight.com/docs/development/modes#airmode\" target=\"_blank\" rel=\"noopener noreferrer\">AirMode</a> on Betaflight.com.",
+ "message": "AirMode is a motor mixer behavior that automatically raises throttle during low-throttle input in order to maintain the craft's authority. For more information please see <a href=\"https://betaflight.com/docs/development/modes#airmode\" target=\"_blank\" rel=\"noopener noreferrer\">AirMode</a> on Betaflight.com.",
"description": "Help text to AIRMODE mode"
},
"auxiliaryHelpMode_BEEPER": {
```
either i can PR again, or just let it be.
|
* add ToolTip for AirMode * verbiage changes as requested; plus code re-use * reverse variables; this should retain feature verbiage for non-english until translated. Co-authored-by: Mark Haslinghuis <[email protected]> * Terminology simplification and URL link * Update locales/en/messages.json Co-authored-by: Jan Post <[email protected]> --------- Co-authored-by: Mark Haslinghuis <[email protected]> Co-authored-by: Jan Post <[email protected]>
auxiliaryHelpMode_AIRMODE