Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ToolTip for AirMode #4206

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Oct 9, 2024

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit d8a7b7d
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/671fae1f82c8490008372670
😎 Deploy Preview https://deploy-preview-4206.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis
Copy link
Member

haslinghuis commented Oct 9, 2024

We have this word salad:

image

See auxiliaryHelpMode_AIRMODE

@nerdCopter
Copy link
Member Author

nerdCopter commented Oct 9, 2024

so many words to confuse the pilot 😆 and use of "you" as the pilot. oh i see that came from the .com, how about i link the .com?
EDIT: oh, it came from auxiliaryHelpMode_AIRMODE as well as you pointed out.

@haslinghuis
Copy link
Member

Perhaps:

In standard mode, when roll, pitch, and yaw calculations saturate a motor, all motors are equally reduced. If a motor goes below minimum, it gets clipped off. For example, with throttle just above minimum and a quick roll is attempted, two motors can't go any lower, resulting in half the power (half of the PID gain). If inputs demand more than a 100% difference between high and low motors, the low motors get clipped, causing an imbalance by unevenly reducing the gain.

@nerdCopter nerdCopter marked this pull request as draft October 9, 2024 17:53
@nerdCopter nerdCopter marked this pull request as ready for review October 22, 2024 13:17
@nerdCopter
Copy link
Member Author

  • i've taken it out of draft.
  • personally i don't like the wordiness -- I'd have preferred something much simpler such as Normalizes motor output at low throttle to allow maintaining of the craft., but this is not my call.

@VitroidFPV
Copy link
Member

Such a big pop-over element might cause UX and UI style issues, I think shortening it is more beneficial than having it be fully detailed. If links work in tooltip boxes, might be a good idea to link to the wiki for the full explanation

@nerdCopter
Copy link
Member Author

nerdCopter commented Oct 25, 2024

thanks @VitroidFPV , I really agree, i think i'll revert to short text (+link) next work-week unless there are more comments to the contrary.

@nerdCopter
Copy link
Member Author

@VitroidFPV @KarateBrot @mituritsyn
re-used the first sentence, which allude "pid at min throttle" and linked the .com
thoughts?

@mituritsyn
Copy link
Contributor

thanks @VitroidFPV , I really agree, i think i'll revert to short text (+link) next work-week unless there are more comments to the contrary.

I personnaly vote for @ctzsnooze formulation:
Airmode' == the mixer behaviour where 'throttle is automatically raised, to maintain authority at low throttle. Just need to rephrase a bit

locales/en/messages.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 28, 2024

@haslinghuis haslinghuis merged commit 36e5cf2 into betaflight:master Oct 28, 2024
8 checks passed
@nerdCopter
Copy link
Member Author

nerdCopter commented Oct 28, 2024 via email

@haslinghuis
Copy link
Member

Apologies assumed this was ready after 24 hours cool of period.

@nerdCopter
Copy link
Member Author

nerdCopter commented Oct 28, 2024 via email

demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
* add ToolTip for AirMode

* verbiage changes as requested; plus code re-use

* reverse variables; this should retain feature verbiage for non-english until translated.
Co-authored-by: Mark Haslinghuis <[email protected]>

* Terminology simplification and URL link

* Update locales/en/messages.json

Co-authored-by: Jan Post <[email protected]>

---------

Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Jan Post <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants