Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual connection option #3703

Merged
merged 2 commits into from
May 8, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 29, 2023

  • Have observed users clicking the connect button without any connection available making manual connection an option would fix most Failed to open serial port events. During this process port_handler has been optimized.
  • manual optional is now optional - as most users would only use serial connection
  • removes brain overload after refactoring some code in porthandler
  • made currentPorts global simplifying code
  • during development encountered some issues which are fixed in:
    Fix reset options #3932
    Fix virtual reboot and auto-connect #3933
    Fix AT32 detection #3935

image

image

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the manual-option branch 2 times, most recently from d61003a to f39f379 Compare December 29, 2023 01:23

This comment has been minimized.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 29, 2023
@blckmn
Copy link
Member

blckmn commented Dec 29, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

I don't understand. What is the problem with JQuery? I understand is old technology and if we can get rid of it, great. But remove it to go with plain javascript, does not seem a good option to me.
The idea was go to Vue (or any other technology that we decide and simplifies the code) but not to plain javascript.

@haslinghuis haslinghuis changed the title Add manual connection option and refactor port_handler to get away from jquery Add manual connection option and optimize port_handler Dec 29, 2023
@haslinghuis
Copy link
Member Author

Agree Vue was adapted some time ago and thought this move was creating a path for further migration.

@haslinghuis
Copy link
Member Author

@McGiverGim @chmelevskij please assist in getting this to use Vue as requested.

@haslinghuis haslinghuis force-pushed the manual-option branch 2 times, most recently from f039bf3 to a6cde85 Compare December 30, 2023 21:22

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the manual-option branch 2 times, most recently from 80bef7a to 7ae0da7 Compare May 5, 2024 22:14

This comment has been minimized.

@haslinghuis haslinghuis marked this pull request as ready for review May 5, 2024 22:22
@haslinghuis haslinghuis dismissed blckmn’s stale review May 5, 2024 22:56

requesting new review

@haslinghuis
Copy link
Member Author

haslinghuis commented May 6, 2024

Testing. Just a minor display issue. Need to hide that while rebooting.

image

EDIT: fixed in 70b68d8
EDIT 2: rebased on master

This comment has been minimized.

This comment has been minimized.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 6, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

nerdCopter commented May 8, 2024

3785b9f5
rm ~/.config/betaflight-configurator/

  • clicking connect with no FC, does nothing; no errors, logs, nor console. 🚀
  • toggling Enable manual connection mode properly add/removes manual Selection from drop-down and also shows/hides manual port field. 🚀
  • flash & pseudo-setup unsolderd FC worked fine.
  • moving from VTX tab to LED Strip tab, went to click on an item, and tab jumped back to VTX tab. most-likely unrelated to this PR and most likely a timing/promise issue.

@haslinghuis haslinghuis merged commit 6105210 into betaflight:master May 8, 2024
12 checks passed
@haslinghuis haslinghuis deleted the manual-option branch May 8, 2024 18:01
VitroidFPV pushed a commit to VitroidFPV/betaflight-configurator that referenced this pull request May 13, 2024
* Hide manual connection and refactor port_handler

* Rebased
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants