-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
started on api docs #4
Open
dominictarr
wants to merge
24
commits into
bentomas:master
Choose a base branch
from
dominictarr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging in stdio breaks it... beginning to rewrite runFile to use some other means of communication. moved message functions into async_testing/lib/messages.js
found a couple of problems with child, tests that logged stuff was breaking reporting, and you could make false positives by outputting a finish message (indicating 0 tests, which is success(!)) started working on another child process implementation, using http. but realised that the messages must be queued, so that they arrive in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi
started on API docs, runSuite (which i've been using) should be correct, other functions I havn't tested yet so they may not be quite right.
although there are already some docs, I wanted to start pure API that are more rigorous that getting-started style stuff. Also, to thresh out what the interface is...
it's hard to work with an open source project when the interface is changing.
we need a consistant, flexible and stable interface.
for example, I like that onSuiteDone is called for every different way that a suite can end, but it's difficult if an argument changes it's structure in different cases, unless there is a very good reason to do so...