Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: authorization #8

Merged
merged 33 commits into from
Nov 15, 2024
Merged

feat: authorization #8

merged 33 commits into from
Nov 15, 2024

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Oct 16, 2024 •
edited
Loading

Implementation of the authorization plugin.

  • Users create a custom authz middleware by extending BaseAuthzMiddleware
  • Custom authz check functions are resolved using dependency injection
  • Users can bring in extra configurations with a mounted .env file
  • Users can bring in extra dependencies with a mounted requirements.txt file

Partially integrated in bento here

davidlougheed
davidlougheed reviewed Oct 25, 2024
View reviewed changes
run.bash Outdated Show resolved Hide resolved
run.dev.bash Outdated Show resolved Hide resolved
transcriptomics_data_service/authz/plugin.py Outdated Show resolved Hide resolved
davidlougheed
davidlougheed reviewed Nov 6, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/authz.md Outdated Show resolved Hide resolved
etc/authz-extra-dep/authz.module.py Outdated Show resolved Hide resolved
transcriptomics_data_service/authz/plugin.py Outdated Show resolved Hide resolved
transcriptomics_data_service/main.py Show resolved Hide resolved
transcriptomics_data_service/routers/experiment_results.py Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Nov 13, 2024
View reviewed changes
authz_plugins/bento/authz.module.py Outdated Show resolved Hide resolved
transcriptomics_data_service/config.py Outdated Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v-rocheleau v-rocheleau merged commit 2ee4f5f into main Nov 15, 2024
3 checks passed
@v-rocheleau v-rocheleau deleted the feat/authz branch November 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-rocheleau @davidlougheed