Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file name prop on DownloadButton should be optional #438

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: file name prop on DownloadButton should be optional #438

merged 1 commit into from
Sep 10, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

Base automatically changed from feat/katsu-config to master September 10, 2024 17:30
@davidlougheed davidlougheed marked this pull request as ready for review September 10, 2024 17:31
v-rocheleau
v-rocheleau approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidlougheed davidlougheed merged commit 77e2afe into master Sep 10, 2024
3 checks passed
@davidlougheed davidlougheed deleted the fix/download-button-type branch September 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @v-rocheleau