Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: new drop box JSON select form input + fixed JSON type #437

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

davidlougheed
Copy link
Member

trying here to address some of the visual hierarchy issues with the DropBoxJsonSelect component, plus splitting/reorganizing the files between it and DropBoxTreeSelect. This also converts DropBoxJsonSelect into a real form input, usable inside a Form.Item.

also fixes a bad JSON type for typescript.

@davidlougheed davidlougheed marked this pull request as ready for review September 9, 2024 18:15
};

/** A form input component for DropBox JSON file selection. */
const DropBoxJsonSelect = ({ initialValue, onChange }: DropBoxJsonSelectProps) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better, thanks! I think I might add a radio option for "None", since Discovery config is optional.
The user can submit an empty discovery config by selecting nothing, but I don't think it is clear enough to the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good idea!

@davidlougheed davidlougheed merged commit 0122679 into feat/katsu-config Sep 9, 2024
3 checks passed
@davidlougheed davidlougheed deleted the style/drop-box-json-input branch September 9, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants