Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scoped discovery config #404

Merged
merged 49 commits into from
Sep 10, 2024
Merged

feat: scoped discovery config #404

merged 49 commits into from
Sep 10, 2024

Conversation

v-rocheleau
Copy link
Contributor

No description provided.

@v-rocheleau v-rocheleau marked this pull request as ready for review May 27, 2024 16:13
davidlougheed
davidlougheed requested changes May 30, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass / initial comments

src/propTypes.js Outdated Show resolved Hide resolved
src/utils/files.ts Outdated Show resolved Hide resolved
src/modules/user/actions.js Outdated Show resolved Hide resolved
src/modules/services/hooks.js Outdated Show resolved Hide resolved
src/modules/services/hooks.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetForm.js Outdated Show resolved Hide resolved
src/components/datasets/DatasetForm.js Outdated Show resolved Hide resolved
src/components/App.js Outdated Show resolved Hide resolved
src/modules/services/hooks.js Outdated Show resolved Hide resolved
src/modules/services/hooks.js Outdated Show resolved Hide resolved
v-rocheleau and others added 16 commits May 30, 2024 21:35
@v-rocheleau
dats json schema validation
92bb011
@v-rocheleau
new schemas endpoint, dats object validation
5967298
@v-rocheleau
lint crash example
d8dcc15
@v-rocheleau
lint
f07b84b
@v-rocheleau
address comments + lint
2a1185f
@v-rocheleau
rm log
5785ff8
@davidlougheed
Merge remote-tracking branch 'origin/master' into feat/katsu-config
4051908 
# Conflicts:
#	package-lock.json
#	src/components/App.js
#	src/components/datasets/DatasetForm.js
#	src/components/datasets/DatasetFormModal.js
#	src/components/display/FileDisplay.js
#	src/components/manager/projects/Project.js
#	src/components/manager/projects/ProjectCreationModal.js
#	src/components/manager/projects/ProjectForm.js
#	src/components/manager/projects/RoutedProject.js
#	src/hooks.ts
#	src/modules/discovery/actions.js
#	src/modules/discovery/reducers.js
#	src/modules/services/actions.js
#	src/modules/services/hooks.js
#	src/modules/user/actions.js
#	src/propTypes.js
@davidlougheed
cleanup
f1ee32d
@davidlougheed
lint
4d7d2c7
@davidlougheed
refact: hooks setup
aa0f98e
@davidlougheed
refact: move drop-box-related code into drop box module
728af99
@davidlougheed
fix: build + lint
d305cad
@davidlougheed
refact(dropBox): move useDropBoxFileContent to drop box module
dd069fe
@davidlougheed
Merge pull request #425 from bento-platform/refact/drop-box-module
ae4dcaf 
refact: move drop-box-related code into drop box module
@davidlougheed
lint: hook dependencies
f327123
@davidlougheed
lint(dropBox): import type
4667596
davidlougheed and others added 14 commits August 19, 2024 16:01
@davidlougheed
lint(manager): functional state update for project state
04deaa9
@davidlougheed
Merge branch 'refact/func-state-updates' into feat/katsu-config
e90a786 
# Conflicts:
#	src/components/manager/projects/Project.js
@davidlougheed
Merge remote-tracking branch 'origin/master' into feat/katsu-config
6435bc1 
# Conflicts:
#	src/components/datasets/DatasetFormModal.js
#	src/components/manager/DropBoxTreeSelect.js
#	src/components/manager/projects/Project.js
#	src/components/manager/projects/ProjectCreationModal.js
#	src/components/manager/projects/ProjectForm.js
@v-rocheleau
dropbox form json data hook
e014605
@v-rocheleau
refact: discovery module moved to metadata
fae54e8
@v-rocheleau
chore: rm discovery module
0beac8e
@v-rocheleau
refact: factor metadata actions, address comments
ad330d0
@v-rocheleau
fix: dataset form fields reset and initial values
491bd05
@v-rocheleau
lint
b58bd1e
@v-rocheleau
refact: form instance hook, avoids passing form as prop
d7f49f2
@davidlougheed
refact: new drop box JSON select form input + fixed JSON type
1d6e43f
@davidlougheed
lint: clean up outdated comment
25a6539
@davidlougheed
chore: cleaner onChange call in DropBoxJsonSelect
b6cb242
@davidlougheed
Merge pull request #437 from bento-platform/style/drop-box-json-input
0122679 
refact: new drop box JSON select form input + fixed JSON type
davidlougheed
davidlougheed requested changes Sep 9, 2024
View reviewed changes
src/components/manager/projects/RoutedProject.js Outdated Show resolved Hide resolved
src/components/manager/projects/Project.js Outdated Show resolved Hide resolved
src/components/manager/dropBox/DropBoxJsonSelect.tsx Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing; otherwise looks good.

src/components/datasets/DatasetForm.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v-rocheleau v-rocheleau merged commit 407da98 into master Sep 10, 2024
3 checks passed
@v-rocheleau v-rocheleau deleted the feat/katsu-config branch September 10, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-rocheleau @davidlougheed