Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15] feat: phenopacket v2 frontend integration #311

Merged
merged 41 commits into from
Nov 28, 2023
Merged

[15] feat: phenopacket v2 frontend integration #311

merged 41 commits into from
Nov 28, 2023

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Oct 11, 2023 •
edited
Loading

This PR goes with the Katsu PR-380.

  • New Individual explorer tabs: Interpretations, Medical Actions (WIP), Measurements (WIP)
  • Removed Individual explorer tabs: Variants, Genes (now both within Interpretations)

@v-rocheleau v-rocheleau marked this pull request as draft October 11, 2023 00:16
@davidlougheed davidlougheed changed the title [WIP][14] feat: phenopacket v2 frontend integration [WIP][15] feat: phenopacket v2 frontend integration Nov 2, 2023
@davidlougheed davidlougheed changed the title [WIP][15] feat: phenopacket v2 frontend integration [WIP] [15] feat: phenopacket v2 frontend integration Nov 2, 2023
davidlougheed
davidlougheed requested changes Nov 22, 2023
View reviewed changes
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualDiseases.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualMeasurements.js Outdated Show resolved Hide resolved
src/components/explorer/TimeElement.js Show resolved Hide resolved
src/components/explorer/TimeElement.js Outdated Show resolved Hide resolved
src/components/explorer/utils.js Outdated Show resolved Hide resolved
src/components/explorer/ExplorerIndividualContent.js Outdated Show resolved Hide resolved
src/components/explorer/ExplorerIndividualContent.js Show resolved Hide resolved
@v-rocheleau v-rocheleau marked this pull request as ready for review November 23, 2023 21:30
@v-rocheleau v-rocheleau changed the title [WIP] [15] feat: phenopacket v2 frontend integration [15] feat: phenopacket v2 frontend integration Nov 23, 2023
davidlougheed
davidlougheed requested changes Nov 24, 2023
View reviewed changes
src/components/explorer/ExplorerIndividualContent.js Show resolved Hide resolved
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualMeasurements.js Show resolved Hide resolved
src/components/explorer/IndividualBiosamples.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualOverview.js Show resolved Hide resolved
src/components/explorer/IndividualPhenotypicFeatures.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualVariants.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualOverview.js Outdated Show resolved Hide resolved
src/components/explorer/searchResultsTables/BiosamplesTable.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this + tables styling should be the last things

src/components/explorer/IndividualInterpretations.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualInterpretations.js Outdated Show resolved Hide resolved
src/components/explorer/IndividualInterpretations.js Show resolved Hide resolved
davidlougheed
davidlougheed approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@v-rocheleau v-rocheleau merged commit 91a0d46 into master Nov 28, 2023
3 checks passed
@davidlougheed davidlougheed deleted the feat/phenov2 branch January 31, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-rocheleau @davidlougheed