Skip to content

Commit

Permalink
Merge pull request #279 from bento-platform/fix/last-runs-loading
Browse files Browse the repository at this point in the history
fix: missing loading indicator for last ingestions table
  • Loading branch information
davidlougheed authored Aug 8, 2023
2 parents 9fd4f65 + 7f580e6 commit bdda1be
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions src/components/manager/runs/RunLastContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,21 @@ const processIngestions = (data, currentTables) => {
};

const LastIngestionTable = () => {
const runs = useSelector((state) => state.runs.items);
const currentTables = useSelector((state) => state.projectTables.items);
const servicesFetching = useSelector(state => state.services.isFetchingAll);
const {items: runs, isFetching: runsFetching} = useSelector((state) => state.runs);
const {
items: currentTables,
isFetching: projectTablesFetching,
} = useSelector((state) => state.projectTables);
const ingestions = useMemo(() => processIngestions(runs, currentTables), [runs, currentTables]);

return <Table bordered={true} columns={COLUMNS_LAST_CONTENT} dataSource={ingestions} rowKey={buildKeyFromRecord} />;
return <Table
bordered={true}
columns={COLUMNS_LAST_CONTENT}
loading={servicesFetching || runsFetching || projectTablesFetching}
dataSource={ingestions}
rowKey={buildKeyFromRecord}
/>;
};

export default LastIngestionTable;

0 comments on commit bdda1be

Please sign in to comment.