Merge pull request #364 from bento-platform/fixes/excluded

"negated" -> "excluded" for phenotypic features
bento-platform · Feb 8, 2024 · 21f42ca · 21f42ca
2 parents 5f82cf9 + 1c78cbd
commit 21f42ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/explorer/IndividualPhenotypicFeatures.js b/src/components/explorer/IndividualPhenotypicFeatures.js
@@ -10,7 +10,7 @@ const PHENOTYPIC_FEATURES_COLUMNS = [
     {
         title: "Feature",
         key: "feature",
-        render: ({ header, type, negated }) => ({
+        render: ({ header, type, excluded }) => ({
             children: header ? (
                 <h4 style={{ marginBottom: 0 }} className="phenotypic-features--phenopacket-header">
                     Phenopacket:{" "}
@@ -20,7 +20,7 @@ const PHENOTYPIC_FEATURES_COLUMNS = [
                 </h4>
             ) : <>
                 <OntologyTerm term={type} />{" "}
-                {negated ? (
+                {excluded ? (
                     <span style={{ color: "#CC3333" }}>
                         (<span style={{ fontWeight: "bold" }}>Excluded:</span>{" "}
                         Found to be absent{" "}
@@ -73,7 +73,7 @@ const IndividualPhenotypicFeatures = ({ individual }) => {
             }] : []),  // If there is just 1 phenopacket, don't include a header row
             ...(p.phenotypic_features ?? []).map((pf) => ({
                 ...pf,
-                key: `${p.id}:${pf.type.id}:${pf.negated}`,
+                key: `${p.id}:${pf.type.id}:${pf.excluded}`,
             })),
         ]);
     }, [individual]);

diff --git a/src/propTypes.js b/src/propTypes.js
@@ -220,6 +220,7 @@ export const diseasePropTypesShape = PropTypes.shape({
 // Prop types object shape for a single phenopacket phenotypic feature object.
 export const phenotypicFeaturePropTypesShape = PropTypes.shape({
     type: ontologyShape.isRequired,
+    excluded: PropTypes.bool,
     created: PropTypes.string,  // ISO datetime string
     updated: PropTypes.string,  // ISO datetime string
 });