feat: URL context-aware sider, header, router #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/scope-specific-menu
gsfk
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Working well, makes the connection between scope and menu items a bit more clear.
Would be nice eventually to have the connection more clear visually (the scope and menu items are far apart from each other on the page)... but I don't have a concrete suggestion. Maybe the data catalogue will clear this up.
|
I think it'll be a multi-PR process with the catalogue and perhaps rearranging the scope menu / replacing it with something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.