Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scoping to beacon UI #241

Merged
merged 6 commits into from
Jan 24, 2025
Merged

add scoping to beacon UI #241

merged 6 commits into from
Jan 24, 2025

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Dec 17, 2024 •
edited
Loading

First pass at scope-aware Beacon UI.

Requires beacon scoping PR.

davidlougheed
davidlougheed reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me (pending Beacon as mentioned)

@gsfk
Copy link
Member Author

gsfk commented Jan 22, 2025

looks good to me (pending Beacon as mentioned)

Still has a few too many renders... it loads full scope first, then re-renders with selected scope.

@davidlougheed
Copy link
Member

there's a scopeSet property that may help here (on the selectedScope return object)

@gsfk gsfk marked this pull request as ready for review January 24, 2025 16:17
@gsfk gsfk changed the title first pass at adding scoping to beacon UI add scoping to beacon UI Jan 24, 2025
@gsfk gsfk requested a review from davidlougheed January 24, 2025 16:34
davidlougheed
davidlougheed approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit 283d1c8 into main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed