feat: UI query:data permissions awareness for counts #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsfk
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Seems to work correctly... no-results dashes is a really long line now?
We can get this working for beacon soon, although I'm undecided whether the correct approach for beacon is to (1) look for the absence of a censorship message in the response, or (2) just add a "this result isn't censored" message to uncensored zeros results.
|
I can change it back, I hated the non-em dashes but that's personal preference For beacon, I think we can maybe determine this from permissions + the rules count threshold? instead of trying to ascertain it from response |
|
Ah, no point putting dashes back if you hate them. |
create uncensored count hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.