feat: allow for multi-column-width charts and improve responsivity #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
changed the base branch from
refact/upgrade-and-clean-up
to
main
davidlougheed
changed the title
gsfk
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Appears to work as expected, strictly in terms of adjusting the parent container width. (I don't have any map data to try).
A few design notes:
- pages with mixed widths are not filled optimally, since charts always appear in fixed order. I don't know if freeing up the order will make charts harder to manage or not.
- it's a bit confusing that the width control isn't on the chart itself, although "manage charts" does seem like a reasonable place to put this
- we should probably add some width elements to the public config:
- it would be useful to have a configurable default width per chart, since we know in advance for some charts that they will look better wider
- we might not want width controls on all charts (do pie charts need them?). Here I'm mostly thinking of the amount of clutter the controls add to "manage charts". If every chart has controls this won't really matter
|
@gsfk regarding point 3a, there is a configurable default width per chart in config now - although existing configs will not have them and default to |
|
ah, I guess I only have an "old" config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also stores widths in localstorage + redraws charts on width change
making the charts (other than map) behave nicely w/ width change is a separate thing for bento_charts...