chore: update bento_lib to 10.1.0 and move service name to config

bento-platform · Nov 21, 2023 · 358afe3 · 358afe3
1 parent fd86297
commit 358afe3
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/bento_drop_box_service/config.py b/bento_drop_box_service/config.py
@@ -1,5 +1,6 @@
 import json
 
+from bento_lib.logging import LogLevelLiteral
 from fastapi import Depends
 from functools import lru_cache
 from pydantic.fields import FieldInfo
@@ -27,6 +28,7 @@ class Config(BaseSettings):
     bento_container_local: bool = False
 
     service_id: str = str(":".join(list(SERVICE_TYPE.values())[:2]))
+    service_name: str = "Bento Drop Box Service"
     service_data_source: Literal["local"] = "local"
     service_data: str = "data/"
     service_url: str = "http://127.0.0.1:5000"  # base URL to construct object URIs from
@@ -38,7 +40,7 @@ class Config(BaseSettings):
 
     cors_origins: tuple[str, ...]
 
-    log_level: Literal["debug", "info", "warning", "error"] = "debug"
+    log_level: LogLevelLiteral = "debug"
 
     # Make Config instances hashable + immutable
     model_config = SettingsConfigDict(frozen=True)

diff --git a/bento_drop_box_service/constants.py b/bento_drop_box_service/constants.py
@@ -3,12 +3,10 @@
 
 __all__ = [
     "BENTO_SERVICE_KIND",
-    "SERVICE_NAME",
     "SERVICE_TYPE",
 ]
 
 BENTO_SERVICE_KIND = "drop-box"
-SERVICE_NAME = "Bento Drop Box Service"
 SERVICE_TYPE: GA4GHServiceType = {
     "group": "ca.c3g.bento",
     "artifact": BENTO_SERVICE_KIND,

diff --git a/bento_drop_box_service/routes.py b/bento_drop_box_service/routes.py
@@ -10,7 +10,7 @@
 from . import __version__
 from .authz import authz_middleware
 from .backends.dependency import BackendDependency
-from .constants import BENTO_SERVICE_KIND, SERVICE_NAME, SERVICE_TYPE
+from .constants import BENTO_SERVICE_KIND, SERVICE_TYPE
 from .config import ConfigDependency
 from .logger import LoggerDependency
 
@@ -76,7 +76,7 @@ async def service_info(config: ConfigDependency, logger: LoggerDependency) -> Re
     # Spec: https://github.com/ga4gh-discovery/ga4gh-service-info
     return JSONResponse(await build_service_info({
         "id": config.service_id,
-        "name": SERVICE_NAME,
+        "name": config.service_name,
         "type": SERVICE_TYPE,
         "description": "Drop box service for a Bento platform node.",
         "organization": SERVICE_ORGANIZATION_C3G,

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -19,7 +19,7 @@ classifiers = [
 
 [tool.poetry.dependencies]
 python = "^3.10.0"
-bento-lib = {extras = ["fastapi"], version = "^10.0.0"}
+bento-lib = {extras = ["fastapi"], version = "^10.1.0"}
 aiofiles = "^23.1.0"
 fastapi = "^0.104.0"
 werkzeug = "^3.0.1"