Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't create unneeded networks #289

Draft
wants to merge 1 commit into
base: releases/v18
Choose a base branch
from
Draft

chore: don't create unneeded networks #289

wants to merge 1 commit into from

Conversation

davidlougheed
Copy link
Member

before this, networks for turned-off features would be created.

@davidlougheed
chore: don't create unneeded networks
1a93daf 
before this, networks for turned-off features would be created.
v-rocheleau
v-rocheleau requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network creation is as expected now.
One issue, when the feature flags are off, bentoctl run encounters missing network errors.

@davidlougheed
Copy link
Member Author

hmmm. maybe these are needed then...

@v-rocheleau
Copy link
Contributor

hmmm. maybe these are needed then...

From what I gather this is caused by the gateway compose file, which always expects these networks.
So I think we would need to template them there if we want to have optional networks.

@davidlougheed
Copy link
Member Author

i'll reconvert this to draft.

@davidlougheed davidlougheed marked this pull request as draft November 26, 2024 19:37
@davidlougheed davidlougheed changed the base branch from releases/v17.1 to releases/v18 December 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @v-rocheleau