Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle special chars & add project folders #12

Closed
wants to merge 1 commit into from

Conversation

pugooo
Copy link
Contributor

@pugooo pugooo commented Nov 13, 2022

This closes #8 and is a simple approach regarding #9.

Regarding #8: Colons are removed. All the other special chars are replaced by '-'.
Regarding #9: After issue retrieval it will also fetch related projects. It will then create a folder per project and place issues inside the folder.

@benr77
Copy link
Owner

benr77 commented Nov 13, 2022

Hello. Thanks for your input! Sorry but I won't merge it like this as it's a mixture of coding standards fixes, a bug fix and a new feature.

Please can you submit separate PRs for

I'm not sure your solution to the project related stuff in #9 actually addresses the problem either - can we flesh this out more in the issue before you submit a PR.

I also think there's a problem with the Windows filename bugfix as you are regexing the issue title which is used in the issue note itself. We only need the filename to be fixed up, so this needs doing here instead:

return this.settings.outputDir + '/' + issue.title + '.md';

Thanks.

@pugooo pugooo closed this Nov 13, 2022
@pugooo
Copy link
Contributor Author

pugooo commented Nov 13, 2022

I issued a new PR for #8.
Regarding #9 I agree, that my approach doesn't resolve the whole requirement.
Are you ok, if I open a new issue regarding my simple approach and submit a PR for that, as it already improves the usability. It also shouldn't be a problem to then flesh it out more in the future for #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct issue names to be compatible with file path (on windows)
2 participants