Merge pull request #1 from benoitblanc/use-context-manager

Use context manager
benoitblanc · Apr 18, 2024 · df3fadc · df3fadc
2 parents 191c8b1 + accfc55
commit df3fadc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 15 deletions.
diff --git a/requirements/requirements.txt b/requirements/requirements.txt
@@ -1,7 +1,7 @@
-Flask==2.3.2
-flask-restx==1.1.0
-Flask-JWT-Extended==4.4.4
-SQLAlchemy==1.4.48
-psycopg2==2.9.6
+Flask==3.0.0
+flask-restx==1.3.0
+Flask-JWT-Extended==4.6.0
+SQLAlchemy==2.0.29
+psycopg2==2.9.9
 requests==2.31.0
-qwc-services-core==1.3.19
+qwc-services-core==1.3.26
diff --git a/search_service.py b/search_service.py
@@ -60,16 +60,18 @@ def search(self, searchtext):
                 )
             )
             self.logger.debug(f"SQL Query : {sql}")
-            conn = self.db_engine.db_engine(document["db_url"]).connect()
             results[key] = []
-            try:
-                result = conn.execute(sql)
-                for row in result:
-                    row_result = self._feature_from_query(row, document["primary_key"])
-                    results[key].append(row_result)
-                self.logger.debug(f"SQL Result for document {key} : {results[key]}")
-            except Exception as e:
-                self.logger.error(f"Error for document {key} on query {sql}: {e}")
+            with self.db_engine.db_engine(document["db_url"]).connect() as conn:
+                try:
+                    result = conn.execute(sql)
+                    for row in result:
+                        row_result = self._feature_from_query(
+                            row, document["primary_key"]
+                        )
+                        results[key].append(row_result)
+                    self.logger.debug(f"SQL Result for document {key} : {results[key]}")
+                except Exception as e:
+                    self.logger.error(f"Error for document {key} on query {sql}: {e}")
         return results
 
     def _feature_from_query(self, row, primary_key):