Internal Clock Enhancements #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djphazer
changed the title
djphazer
force-pushed
the
clock-setup-tweaks
branch
from
fa81aaf to
04d6ef2
Compare
|
After sufficient time and testing, I've rebased and squashed this down into a single commit. It's quite functional, but some code review would be a good idea... Also, it probably depends on #59 to fit in memory |
Spyes
reviewed
Jan 11, 2023
software/o_c_REV/HEM_ClockSetup.ino
Outdated
| @@ -91,44 +108,91 @@ protected: | |||
| } | |||
|
|
|||
| private: | |||
| int cursor; // 0=Source, 1=Tempo, 2=Multiply | |||
| char cursor; // 0=Play/Stop, 1=Forwarding, 2=External PPQN, 3=Tempo, 4,5=Multiply | |||
There was a problem hiding this comment.
Might be worthwhile to extract this to an enum, it'll make it much easier to understand at a glance the different cursor states
There was a problem hiding this comment.
Yeah, and there's probably a cursor variable in every other applet that should be an enum... I'll work on this.
software/o_c_REV/HSClockManager.h
Outdated
Comment on lines
47
to
62
| bool tock[3] = {0,0,0}; // The current tock value | ||
| int tocks_per_beat[3] = {1, 1, 24}; // Multiplier | ||
| int clock_ppqn = 4; // external clock multiple | ||
| bool cycle = 0; // Alternates for each tock, for display purposes | ||
| int count[3] = {0,0,0}; // Multiple counter, 0 is a special case when first starting the clock | ||
|
|
||
| bool boop[4]; // Manual triggers |
There was a problem hiding this comment.
consider extracting hard-coded array lengths to consts
* Adapts to external clock at configurable PPQN (0 to disable) * Separate internal clock multipliers/dividers for each hemisphere (0 to disable) * Internal Clock sends realtime MIDI Clock/Start/Stop * Forwarding only duplicates physical DIGITAL 1 -> DIGITAL 3 * Clock state data is stored with ClockSetup, not Metronome
djphazer
force-pushed
the
clock-setup-tweaks
branch
from
04d6ef2 to
5cec6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly elegant solution to #23 that's hopefully not too intrusive.
Clock Forwarding and internal clock Start/Stop are now independent settings. On the ClockSetup screen, turn encoder left to toggle Start/Stop, turn right to toggle Forwarding, indicated by a LINK_ICON. Long-press left encoder will still Pause/Unpause.
Internal clock always triggers Digital 1, will only trigger Digital 3 if forwarding is ON.
Functionally, I think it's exactly what I wanted. Open to feedback on the interface screen.