Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beniaminogreen I already added support for
join_by()
in another package so I figured it would be easier for me to do it here. I hope this is fine.This PR:
join_by()
both for Euclidean and Jaccard joins (with some tests)@inheritParams
. I think all arguments in each family are the same, the only thing that changes is the function name, I hope I didn't miss anythingroxygen2
Close #93