Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dplyr::join_by() #95

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Support for dplyr::join_by() #95

merged 3 commits into from
Jan 16, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Jan 15, 2024

@beniaminogreen I already added support for join_by() in another package so I figured it would be easier for me to do it here. I hope this is fine.

This PR:

  • adds support for join_by() both for Euclidean and Jaccard joins (with some tests)
  • reduces duplication of arguments description by using @inheritParams. I think all arguments in each family are the same, the only thing that changes is the function name, I hope I didn't miss anything
  • adds a small modif to document the "PACKAGE" object due to update of roxygen2
  • adds myself as contributor

Close #93

@beniaminogreen
Copy link
Owner

This is fantastic! Thanks for your contribution, and for writing tests around it! Merging in now.

@beniaminogreen beniaminogreen merged commit 9e4270b into beniaminogreen:main Jan 16, 2024
7 checks passed
@etiennebacher etiennebacher deleted the support-join-by branch January 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support join_by()
2 participants