Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #116

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Increase code coverage #116

merged 1 commit into from
Feb 15, 2024

Conversation

etiennebacher
Copy link
Collaborator

It's already quite high, but trying to get closer to 100% ;)

  • add tests for anti_join() (only join type untested so far)
  • add snapshots for graphs
  • add test for arg similarity_column for Hamming joins

@etiennebacher etiennebacher merged commit 03799b9 into main Feb 15, 2024
7 checks passed
@etiennebacher etiennebacher deleted the increase-codecov branch February 15, 2024 14:50
@etiennebacher etiennebacher restored the increase-codecov branch February 15, 2024 14:50
@etiennebacher etiennebacher deleted the increase-codecov branch February 15, 2024 14:50
@beniaminogreen
Copy link
Owner

Looks great! I have to look at how you tested the graphs because I had no idea how to do that!

@etiennebacher
Copy link
Collaborator Author

I use snapshot testing for this, here are some useful slides that explain it: https://indrajeetpatil.github.io/intro-to-snapshot-testing/#/introduction-to-snapshot-testing-in-r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants