Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup lintr and fix a few lints #112

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Setup lintr and fix a few lints #112

merged 5 commits into from
Feb 14, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Feb 14, 2024 •
edited
Loading

Use lintr::lint_package() or lint_dir("R") to run it. A couple of changes:

  • anyNA() is more efficient than any(is.na())
  • better to use || or && in if conditions as those are vectorised versions of | and &

@etiennebacher
Copy link
Collaborator Author

There are some conflicts due to merging main, I'll take care of this

@etiennebacher etiennebacher merged commit 090a56d into main Feb 14, 2024
7 checks passed
@etiennebacher etiennebacher deleted the lints branch February 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @beniaminogreen