Skip to content

Commit

Permalink
adding DOI's to DESCRIPTION, removing use of installed_packages
Browse files Browse the repository at this point in the history
  • Loading branch information
beniaminogreen committed Jan 29, 2024
1 parent 8d7e4d4 commit 5e9209c
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 15 deletions.
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.1.2
Date: 2024-01-23 20:33:15 UTC
SHA: 4b0883574abdb589e78bf7242dce2c4c9f2dd430
Version: 0.1.3
Date: 2024-01-26 18:42:08 UTC
SHA: 8d7e4d4d3130680919fa79646ddd0e06b3857002
10 changes: 5 additions & 5 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ Authors@R: c(
person("Beniamino", "Green", , "[email protected]", role = c("aut", "cre", "cph")),
person("Etienne", "Bacher", email = "[email protected]", role = "ctb"),
person(given = "The authors of the dependency Rust crates",
role = c("ctb"),
role = c("ctb", "cph"),
comment = "see inst/AUTHORS file for details")
)
Description: Empowers users to fuzzily-merge data frames with millions or tens of millions of rows in minutes with low memory usage. The package uses two locality sensitive hashing algorithms to avoid having to compare every pair of records in each dataset, resulting in fuzzy-merges that finish in linear time.
Description: Empowers users to fuzzily-merge data frames with millions or tens of millions of rows in minutes with low memory usage. The package uses the locality sensitive hashing algorithms developed by Datar, Immorlica, Indyk and Mirrokni (2004) <doi:10.1145/997817.997857>, and Broder (1998) <doi:10.1109/SEQUEN.1997.666900> to avoid having to compare every pair of records in each dataset, resulting in fuzzy-merges that finish in linear time.
License: GPL (>= 3)
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand All @@ -19,18 +19,18 @@ Imports:
tibble,
tidyr
Suggests:
arrow,
babynames,
covr,
fuzzyjoin,
igraph,
knitr,
microbenchmark,
rmarkdown,
stringdist,
testthat (>= 3.0.0),
tidyverse,
purrr
purrr,
microbenchmark,
profmem
Config/testthat/edition: 3
URL: https://beniamino.org/zoomerjoin/
BugReports: https://github.com/beniaminogreen/zoomerjoin/issues/
Expand Down
2 changes: 1 addition & 1 deletion R/string_group.R
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
#' @importFrom utils installed.packages
jaccard_string_group <- function(string, n_gram_width = 2, n_bands = 45, band_width = 8, threshold = .7, progress = FALSE) {

if (!"igraph" %in% rownames(utils::installed.packages())) {
if (system.file(package = "igraph")=="") {
stop("library 'igraph' must be installed to run this function")
}

Expand Down
7 changes: 7 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,10 @@ reference:
- euclidean_curve
- euclidean_probability

- title: data
contents:
- dime_data

- title: Miscellaneous
contents:
- zoomerjoin-package
6 changes: 2 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
## Resubmission
This is a resubmission. In this version I have:

* Removed a large data file accidentally included in the vignettes/ directory
which caused the package tarball to be too large for CRAN
* Removed some unnecessary documentation included with rust sources to bring
the package size down to < 5 MB
* Added DOI's and author names to DESCRIPTION file.
* Removed usage of installed.packages to detect if optional dependency `igraph` is installed.


4 changes: 2 additions & 2 deletions man/zoomerjoin-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5e9209c

Please sign in to comment.