Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passes pageSize to initial setData call #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mr-winter
Copy link

Adds pageSize to extraParameters for initial remote setData call.
Also gitignores intellij idea folder.

@codecov-io
Copy link

codecov-io commented Aug 24, 2017

Codecov Report

Merging #174 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   75.78%   76.01%   +0.22%     
==========================================
  Files         111      112       +1     
  Lines        5097     5144      +47     
  Branches      366      366              
==========================================
+ Hits         3863     3910      +47     
- Misses        957      958       +1     
+ Partials      277      276       -1
Impacted Files Coverage Δ
src/components/Grid.jsx 80.78% <ø> (+0.59%) ⬆️
src/constants/GridConstants.js 68% <0%> (-0.75%) ⬇️
src/util/stateGetter.js 89.28% <0%> (-0.37%) ⬇️
src/constants/ActionTypes.js 52.22% <0%> (-0.35%) ⬇️
src/components/plugins/editor/inline/Button.jsx 76.25% <0%> (ø) ⬆️
src/components/layout/TableRow.jsx 71.72% <0%> (ø) ⬆️
src/components/layout/TableContainer.jsx 62.5% <0%> (ø) ⬆️
src/util/filterUtils.js 93.54% <0%> (ø)
src/store/configureStore.js 77.27% <0%> (+2.27%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d179a4...b8ff485. Read the comment docs.

@bencripps
Copy link
Owner

I know the current test suite is passing, but are there any new tests we should add to check how this new code affects the current implementation or the newly introduced behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants