Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WOOT-3 fix updates and api keys #30

Merged
merged 6 commits into from
May 12, 2024
Merged

WOOT-3 fix updates and api keys #30

merged 6 commits into from
May 12, 2024

Conversation

bemijonathan
Copy link
Owner

@bemijonathan bemijonathan commented May 12, 2024 •
edited
Loading

Task: Improve credentials handling for Jira and Trello clients

  • Add Jira credentials for authentication in the ci.yml file.
  • Add Trello credentials (commented out) for potential future use in the ci.yml file.
  • Modify the way Trello credentials are retrieved and passed to the TrelloClient constructor in base-client.ts.
  • Modify the way Jira credentials are retrieved and passed to the JiraClient constructor in base-client.ts.
  • Refactor the JiraClient constructor to accept credentials during initialization in jira.ts.
  • Update the initializeJiraClient method to use passed credentials for Jira authentication in jira.ts.
  • Refactor the TrelloClient constructor to accept credentials during initialization in trello.ts.
  • Remove instantiation of the JiraClient as it is no longer being used in index.ts.
  • Modify the method to extract ticket details from pull request details in index.ts.
  • Remove unused method getClientInstance() in index.ts.

Checklist

  • Add Jira credentials for authentication in the ci.yml file.
  • Add Trello credentials (commented out) for potential future use in the ci.yml file.
  • Modify the way Trello credentials are retrieved and passed to the TrelloClient constructor in base-client.ts.
  • Modify the way Jira credentials are retrieved and passed to the JiraClient constructor in base-client.ts.
  • Refactor the JiraClient constructor to accept credentials during initialization in jira.ts.
  • Update the initializeJiraClient method to use passed credentials for Jira authentication in jira.ts.
  • Refactor the TrelloClient constructor to accept credentials during initialization in trello.ts.
  • Remove instantiation of the JiraClient as it is no longer being used in index.ts.
  • Modify the method to extract ticket details from pull request details in index.ts.
  • Remove unused method getClientInstance() in index.ts.

Added by woot! 🚂

@bemijonathan bemijonathan merged commit ea98b4c into main May 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bemijonathan