-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ci #6
Improve ci #6
Conversation
mguid65
commented
May 3, 2024
- Modify CI to use default images from github
- Add windows, linux, and macos
- Note:
- For Ninja, we have to fetch it from an external source
- For Windows, we have to do some work to setup the msvc dev environment
- For both of the above, these are accomplished by using public actions from the marketplace
- This may not be appropriate and so we may have to do something different
|
||
on: | ||
push: | ||
branches: [ main ] | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove:
https://github.com/beman-project/exemplar/blob/d9145b52c9072a569d747547edfc7e03a1494809/.github/workflows/ci_tests.yml#L9-L10
If you intend to merge this change.
Is there any update to this pr? |
I apologize, the reason for the lack of updates is that I forgot I made this PR. We can either continue with proposed changes to this or we can discard it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mguid65 , would you like to update your branch with latest main before continue with this review? Some changes are not applicable anymore.
e.g. Due to one usage examples, now the project requires C++20 or later.
Would you like to try to re-enable this example on your updated branch https://github.com/beman-project/exemplar/blob/main/examples/CMakeLists.txt#L4?
} | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
@@ -1,83 +1,97 @@ | |||
# Copyright © 2024 Bret Brown | |||
# SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you want to remove these lines? I think we should keep them.
btw, @camio , should we add a mention for YAML files into https://github.com/beman-project/beman/blob/main/docs/beman-standard.md#file-contents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, @camio , should we add a mention for YAML files into https://github.com/beman-project/beman/blob/main/docs/beman-standard.md#file-contents?
Sounds like a promising idea. Would you be willing to create a PR or issue for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I will do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged bemanproject/beman#44
I think this PR is abandoned, see: #27 (comment), and the comment above. I can fork this PR and pick this up. |
As per previous reply, I closed this PR to avoid more confusion, we can fork it later. |