Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test reviewdog 2 #58

Closed
wants to merge 4 commits into from
Closed

[DO NOT MERGE] Test reviewdog 2 #58

wants to merge 4 commits into from

Conversation

wusatosi
Copy link
Member

Sorry again for spamming the notification.

Similar to #53 , trying to debug the permission issue of review dog.

Different to #53, this pr opens a pr from within the project instead of a fork.
I suspect the permission issue may be because it's a pr from a fork.

Expected:

  1. pre-commit flags the clang-format and white space linting issue and generates fixes
  2. Review dog suggests fixes via Pull Request reviews.

@wusatosi
Copy link
Member Author

@wusatosi
Copy link
Member Author

why is the pull request event not triggering?????

@wusatosi
Copy link
Member Author

Close the pr as its not helping at all.. Notes the push event is passing which it shouldn't

@wusatosi wusatosi closed this Oct 22, 2024
@wusatosi wusatosi reopened this Oct 22, 2024
@wusatosi wusatosi closed this Oct 22, 2024
@wusatosi wusatosi deleted the bad-format branch October 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant