Run TSan and ASan on every C++ version #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusatosi
requested review from
bretbrownjr,
camio,
dietmarkuehl,
neatudarius and
steve-downey
as code owners
wusatosi
commented
Oct 22, 2024
Comment on lines
+19
to
+26
| name: "Preset Test: ${{ matrix.preset }}" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup cmake | ||
| uses: jwlawson/actions-setup-cmake@v2 | ||
| - name: Setup build environment | ||
| uses: lukka/get-cmake@latest | ||
| with: | ||
| cmake-version: '3.25.x' | ||
| - uses: seanmiddleditch/gha-setup-ninja@v5 | ||
| cmakeVersion: "~3.25.0" | ||
| ninjaVersion: "^1.11.1" |
There was a problem hiding this comment.
Just tidying stuff up here. Giving preset test a better name and use the same setup-cmake action as the one below for consistency.
Merged
camio
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we will be selectively running tests and examples based on C++ version, we should run TSan and ASan on every C++ version variants in CI.
This PR updates the matrix to run three flavors of CMake configuration per compiler per C++ version:
This PR also specifies
CMAKE_CXX_STANDARDfor every run to avoid cmake falling back to older C++ versions.No test case will be removed from this change, total matrix size from build and test increase from 15 to 23.