Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement schedule fault notification #43

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

wusatosi
Copy link
Member

@wusatosi wusatosi commented Oct 3, 2024

closes #36 .

Scheduled build-and-test introduced in #28 is triggering correctly.
But failure at routine build-and-test can be silent, e. g. https://github.com/beman-project/exemplar/actions/runs/11109516669 .

This pr creates a new issue when scheduled build-and-test fails.
To avoid spamming the issue tracker, it will append to an existing open issue with a comment if an appropriate issue exist and is active.

Tested on my own fork, see: wusatosi#6

Copy link
Member

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Does the leading whitespace get trimmed properly in the resulting comments?

@camio camio merged commit e062cfd into bemanproject:main Oct 3, 2024
14 checks passed
@wusatosi
Copy link
Member Author

wusatosi commented Oct 3, 2024

Looks good to me. Does the leading whitespace get trimmed properly in the resulting comments?

Yes, see: wusatosi#6

@camio camio mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be some notification mechanism when scheduled build-test ci fails
3 participants