This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
require a minimum user karma to upvote and downvote #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # If user's karma is less than threshold, thing.votable = False | ||
| # meaning that the voting icons won't appear on posts and comments | ||
| # "karma_to_vote" is only used for voting in polls. | ||
| no_voting_threshold = 10 |
There was a problem hiding this comment.
I think this setting should be renamed to remove the negative no and be clearer about what the value is. The best way to do this may be to rename karma_to_vote to karma_to_vote_on_polls and make this setting karma_to_vote.
|
Agreed, and will do. I was just wary of renaming existing configuration options without encouragement. |
|
@wezm global configuration parameters renamed per your suggestion. |
|
Looks good. @cdaloisio note that ini file changes will be needed before this can be deployed. |
|
Great 👍 Production config values are now as follows: |
cdaloisio
added a commit
that referenced
this pull request
Feb 18, 2016
require a minimum user karma to upvote and downvote
|
Closes #550 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve issue #550.
A new global 'no_voting_threshold' is added. A user's karma must be greater than this value before the upvote and downvote icons will appear (i.e., before thing.votable is set to true). The modification to link.py is made in the two places that also prevent an author from upvoting their own articles and comments.
I modified example.ini, test.ini and provisioning/cookbooks/lesswrong/templates/default/development.ini.erb to include a 'no_voting_threshold' example. It will have to be added to a production .ini file to successfully implement this patch.
Tested with no_voting_threshold at various values. The voting icons appear and disappear depending on user karma as expected.