Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test, for real #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marcosvm
Copy link
Contributor

@marcosvm marcosvm commented Jan 3, 2020

👻

@bejelith

This PR adds other service on the composer docker_entrypoint_integration that will invoke the created executable with the following command line:

/docker_entrypoint -template /etc/server/server.properties.template /bin/cat /etc/server/server.properties

Thus the integration test will fail if the /etc/server/server.properties is not generated. The result of /bin/cat /etc/server/server.properties can be used for visual inspection of the generated file.

The environment variables for substitution in the template are defined in the Dockerfile for the test image test/Dockerfile.test.

vai.sh now run two docker-compose up commands as I could not find a way to fail the test if one of the services failed, docker-compose as returning exit code 0 if so. The drawback is that the test image is built twice but that can be a good thing as isolated both unit and integration tests.

Travis is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant