Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👻
@bejelith
This PR adds other service on the composer
docker_entrypoint_integration
that will invoke the created executable with the following command line:Thus the integration test will fail if the
/etc/server/server.properties
is not generated. The result of/bin/cat /etc/server/server.properties
can be used for visual inspection of the generated file.The environment variables for substitution in the template are defined in the Dockerfile for the test image
test/Dockerfile.test
.vai.sh
now run twodocker-compose up
commands as I could not find a way to fail the test if one of the services failed, docker-compose as returning exit code 0 if so. The drawback is that the test image is built twice but that can be a good thing as isolated both unit and integration tests.Travis is passing.