-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GBulb with PyGObject's native asyncio handling #2550
Conversation
PyGObject==3.50.0 released today. Unfortunately, gbulb is not compatible with it and Gtk apps crash at launch; PyGObject is now expecting the event loop installed by gbulb to provide a I mention it here because PyGObject merged their native async support which included the change that breaks gbulb. Given this PR is intended to use that new functionality, merging this would remove gbulb and this issue with PyGObject==3.50.0. |
Let's do it. I've got no love for maintaining GBulb; the fact that 3.50.0 is backwards incompatible with means there's a good reason to adopt the new API. It's also promising that the final form of this patch needed a tweak to slow down GTK operation so that the probe can observe changes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few questions. i'll test on fedora and arch as well to make sure nothing weird happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's send it.
PyGObject has an in-development branch adding native asyncio integration. This PR replaces GBulb with that branch.
At this point, this is an experiment to provide testing feedback upstream; it is unlikely we'll adopt this before PyGObject merges the branch.
Refs #2548 (an alternate PR removing gbulb)
PR Checklist: