cleaning up galleryvc #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#607 (comment) cleanups landed in this Merge Request. |
krugerk
commented
Jan 14, 2025
Comment on lines
+166
to
+169
| UIBarButtonItem(barButtonSystemItem: .search, target: self, action: #selector(self.searchButtonPressed)) | ||
| ] | ||
| self.navigationItem.rightBarButtonItems = [ | ||
| UIBarButtonItem(image: UIImage(systemName: "gearshape.fill"), style: UIBarButtonItem.Style.plain, target: self, action: #selector(self.settingsButtonPressed)) |
There was a problem hiding this comment.
Suggested change
| UIBarButtonItem(barButtonSystemItem: .search, target: self, action: #selector(self.searchButtonPressed)) | |
| ] | |
| self.navigationItem.rightBarButtonItems = [ | |
| UIBarButtonItem(image: UIImage(systemName: "gearshape.fill"), style: UIBarButtonItem.Style.plain, target: self, action: #selector(self.settingsButtonPressed)) | |
| .init(barButtonSystemItem: .search, target: self, action: #selector(self.searchButtonPressed)) | |
| ] | |
| self.navigationItem.rightBarButtonItems = [ | |
| .init(image: UIImage(systemName: "gearshape.fill"), style: UIBarButtonItem.Style.plain, target: self, action: #selector(self.settingsButtonPressed)) |
krugerk
commented
Jan 14, 2025
Comment on lines
-242
to
-244
| } else { | ||
| self.updateGoals() | ||
| self.fetchGoals() |
There was a problem hiding this comment.
And this functional change
|
Best way I've found to review diffs like this one |
Let's aim for more specificity than this in general. e.g. from this I don't know which cases you tested from having goals / no goals / deadbeat / etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A merge request for various cleanups that were kept out of #607 so as to make for a clean diff.
For UI changes including screenshots of before and after is great.
n/a
Validation
Built app
Ran it in simulator