goalvc was crashing when refreshing its ui for an unavailable goal #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Jan 1, 2025
| self.datapointTableController.datapoints = goal.recentData.sorted(by: {$0.updatedAt < $1.updatedAt}) | ||
| @MainActor func updateInterfaceToMatchGoal() { | ||
| self.datapointTableController?.hhmmformat = goal.hhmmFormat | ||
| self.datapointTableController?.datapoints = goal.recentData.sorted(by: {$0.updatedAt < $1.updatedAt}) |
There was a problem hiding this comment.
Suggested change
| self.datapointTableController?.datapoints = goal.recentData.sorted(by: {$0.updatedAt < $1.updatedAt}) | |
| self.datapointTableController?.datapoints = goal.recentData.sorted(using: SortDescriptor(\.updatedAt)) |
krugerk
commented
Jan 1, 2025
| @@ -312,6 +315,9 @@ class GoalViewController: UIViewController, UIScrollViewDelegate, DatapointTabl | |||
| super.viewDidDisappear(animated) | |||
| lastUpdatedTimer?.invalidate() | |||
| lastUpdatedTimer = nil | |||
| datapointTableController?.delegate = nil | |||
| datapointTableController = nil | |||
| NotificationCenter.default.removeObserver(self) | |||
There was a problem hiding this comment.
Suggested change
| NotificationCenter.default.removeObserver(self) |
docs point out that modern iOS versions take care of this automatically
|
Are you able to reliably repro the crash? If so, what does the memory debugger show at the time? I'm very open to the idea this patch is correct, but would like to understand why. |
no, apparently not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite the changes in #591, a crash was still observed.
For UI changes including screenshots of before and after is great.
Validation
added logging to validate vc being deallocated when expected
in simulator, navigated gallery to goal and back and forth again
#590