no need to assume we are dealing with deadbeats #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
commented
Dec 30, 2024
| @@ -115,6 +115,7 @@ class GalleryViewController: UIViewController, UICollectionViewDelegateFlowLayou | |||
| make.left.equalTo(10) | |||
| make.right.equalTo(-10) | |||
| } | |||
| self.deadbeatView.isHidden = true | |||
There was a problem hiding this comment.
show it when we know better
theospears
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
App started off claiming user is a deadbeat.
The state resulted from recent changes in #583 where the deadbeat view was hidden or not only when a user was logged in and the default state being to show the deadbeat view.
For UI changes including screenshots of before and after is great.
before
after
Validation
signed out, started app anew, signed in
in simulator
Fixes #586