Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ServiceLocator references from GalleryViewController #575

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

theospears
Copy link
Collaborator

@theospears theospears commented Dec 28, 2024

Summary

I'd like to move the app away from having direct references to ServiceLocator and instead have classes gain references to the dependencies they need via dependency injection.

This makes a start in that direction with GalleryViewController. Now this is created in code via SceneDelegate we can pass in its dependencies at construction time.

Validation

  • Verify that the app can launch and show the gallery view
  • Verify it is possible to pull to refresh the goals list

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@theospears theospears changed the title Dependency inject into GalleryViewController" Remove ServiceLocator references from GalleryViewController Dec 28, 2024
@theospears theospears force-pushed the galleryview-dep-injection branch from 5980ee0 to e6f5a4d Compare December 30, 2024 01:00
@theospears theospears marked this pull request as ready for review December 30, 2024 01:01
@theospears theospears requested a review from a team as a code owner December 30, 2024 01:01
@theospears theospears merged commit a47cdad into master Dec 30, 2024
6 checks passed
@theospears theospears deleted the galleryview-dep-injection branch December 30, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant