Deprecate storing user data in UserDefaults #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theospears
changed the title
theospears
force-pushed
the
no-longer-update-userdata
branch
from
ee26833 to
bc3396f
Compare
krugerk
reviewed
Dec 29, 2024
| @@ -82,6 +83,14 @@ public actor CurrentUserManager { | |||
| try! context.save() | |||
| } | |||
|
|
|||
| private nonisolated func cleanUpUserDefaults() { | |||
| for key in CurrentUserManager.allKeys { | |||
| userDefaults.removeObject(forKey: key) | |||
There was a problem hiding this comment.
though this removes not just elements of user but also the access token; not sure if that was intended
There was a problem hiding this comment.
Not strictly intended but I think fine - the access token should be stored in the keychain now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we were double-writing to CoreData and to UserDefaults in case we decided not to move ahead with CoreData. Now we have a public release that is fully migrated to CoreData we are committed to the migration, and don't need to maintain the UserDefaults paths.
This leaves in the code which migrates data from UserDefaults to CoreData, so it it still possible to seamlessly upgrade from previous versions, but removes incremental updates to UserDefaults, and deletes all values after the data has been migrated. This means downgrading from this version to <6.7 will require logging in again.
Validation