Add a CODEOWNERS file #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
reviewed
Dec 29, 2024
| @@ -0,0 +1,2 @@ | |||
| # Request reviews from the iOS app maintainer by default | |||
| * @beeminder/ios-maintainer | |||
There was a problem hiding this comment.
this team has to be created elsewhere, which I am guessing you did
Is it named "a team"? Maybe Beeminder Maintainer or BeeSwift Maintainers could be the name?
There was a problem hiding this comment.
It's called ios-maintainer. Unfortunately github doesn't support making it public: https://github.com/orgs/community/discussions/20808
There was a problem hiding this comment.
This is how those lines show up for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's becoming a little hard for me to keep track of PR states. To help with this, I'm going to experiment with configuring github to request a review from me on all PRs. Then I can filter to PRs waiting on review from me to know which need my attention.
CODEOWNERS appears the simplest way to do this.
Validation
As this is a git change it's hard to verify pre-merge. Will merge, and then check PRs start listing me as a reviewer.