Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of the navigation bar #569

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix styling of the navigation bar #569

merged 1 commit into from
Dec 27, 2024

Conversation

theospears
Copy link
Collaborator

@theospears theospears commented Dec 26, 2024

Summary

In #555 I removed the StoryBoard for the main app view. In doing so I removed some of the custom styling of the Navigation bar at the top of the app, resulting in colored icons and the dark style not being maintained.

Here we bring back styling to match the old behavior.

Validation

Ran in the simulator in light and dark mode.

Before this PR:
before - light.png
before -dark.png

After this PR:
after - light.png
after - dark.png

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@theospears theospears changed the title Fix colors Fix styling of the navigation bar Dec 26, 2024
@theospears theospears marked this pull request as ready for review December 26, 2024 03:59
@theospears theospears merged commit b3b08e3 into master Dec 27, 2024
3 checks passed
@theospears theospears deleted the nav-icon-color branch December 27, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant