more zoom levels and more powerful zoom in on goal graph #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…small allows a bigger zoom and a few more zoom levels
theospears
reviewed
Dec 6, 2024
| let possibleNextStepUp = self.goalImageScrollView.zoomScale + 2.0 | ||
| let nextZoomLevel = possibleNextStepUp <= self.goalImageScrollView.maximumZoomScale ? possibleNextStepUp : self.goalImageScrollView.minimumZoomScale | ||
|
|
||
| self.goalImageScrollView.setZoomScale(nextZoomLevel, animated: true) |
There was a problem hiding this comment.
This seems reasonable for iPhone. I'm less sure it makes sense for iPad though? Perhaps the max zoom level should be a function of the screen size?
There was a problem hiding this comment.
I still found it quite OK to double tap to zoom on the iPad. The bigger issue for me was that the graph image being used quickly becomes blurry since we are using the lower resolution png rather than the svg. The user can still pinch-to-zoom and can do so at the previous level as well as now also at other levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Via double tap on the goal's graph, step through the zoom levels.
One could double tap on the goal's graph to see a zoomed in version. This was at 2x magnification. Now it goes to 7x and from 1x to 3x to 5x and then 7x.
The graph (wrapped still inside a scrollview) still supports the pan to zoom. This zoom's max has also been bumped with this MR.
Validation
Ran the app in the iPhone simulator. Tapped and zoomed on some graphs.