Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the edit datapoint view #413

Merged
merged 7 commits into from
Oct 1, 2023
Merged

Redesign the edit datapoint view #413

merged 7 commits into from
Oct 1, 2023

Conversation

theospears
Copy link
Collaborator

This provides a new look for the edit data point view. In particular:

  • The date picker now works as you might expect
  • It uses styles more consistent with iOS system defaults
  • It's a formSheet rather than a full screen takeover

Testing:

  • Loaded on simulator on iOS15-17
  • Tested changing a data point
  • Tested deleting a data point

@theospears
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@theospears theospears force-pushed the edit-goal-date-picker branch from 65d0eda to d819ab6 Compare October 1, 2023 03:18
@theospears theospears merged commit f080832 into master Oct 1, 2023
@theospears theospears deleted the edit-goal-date-picker branch October 1, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theospears