Update dependencies and enable dependency verification in Gradle #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's another attempt to enable Gradle dependency verification. I've tried to do this a couple of times before, but always ran into issues. With a helper script borrowed from a different project, hopefully this will finally work reliably. Every time we update Gradle or a dependency, the script I mentioned needs to be run to update the list of checksums. The script runs the build, the tests and the instrumented tests. This is necessary because apparently Gradle is not able to discover all dependencies without actually running the build tasks. It's a little bit annoying that this Gradle feature is so half-baked that we need a helper script to make things work, but I think it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another attempt to enable Gradle dependency verification. I've tried to do this a couple of times before (#320, #463) but always ran into issues. With a helper script borrowed from a different project, hopefully this will finally work reliably.
Every time we update Gradle or a dependency, the script I mentioned needs to be run to update the list of checksums. The script runs the build, the tests and the instrumented tests. This is necessary because apparently Gradle is not able to discover all dependencies without actually running the build tasks.
It's a little bit annoying that this Gradle feature is so half-baked that we need a helper script to make things work, but I think it's worth it.